Translate Reconciliation #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for it-react-org ready! Built with commit 78d4995 |
|
✔️ Deploy preview for it-reactjs ready! 🔨 Explore the source changes: 78d4995 🔍 Inspect the deploy logs: https://app.netlify.com/sites/it-reactjs/deploys/6005c034e1e34e000844d0e3 😎 Browse the preview: https://deploy-preview-262--it-reactjs.netlify.app |
|
Any news so far? |
Ciao @mattveraldi! There's a merge conflict, as soon as you fix it I'll review so that we can merge. |
Co-authored-by: Alessandro De Blasis <[email protected]>
Thank you 😄 |
deblasis
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ciao, I finished the issue #71 .
On the "Chiavi" paragraph, I chose to keep using
keyinstead of translating it as 'chiave' because, in my opinion, it is more clear for the user that we are specifically referring to the prop itself, not only the concept. Let me know if it is ok for you to keep using 'key'. If that is the case, maybe we could consider to add it in the Glossary. Let me know if I should fix something on the translation or on the sentences and I will do it asap 😄 👍